fix: CORS issue with ORCID API and refactoring ORCID integration#1317
Merged
vcnainala merged 5 commits intodevelopmentfrom Jan 12, 2026
Merged
fix: CORS issue with ORCID API and refactoring ORCID integration#1317vcnainala merged 5 commits intodevelopmentfrom
vcnainala merged 5 commits intodevelopmentfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #1317 +/- ##
=================================================
+ Coverage 63.32% 63.49% +0.17%
- Complexity 2273 2285 +12
=================================================
Files 208 209 +1
Lines 8780 8821 +41
=================================================
+ Hits 5560 5601 +41
Misses 3220 3220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CORS issues with the ORCID API by moving ORCID API calls from the frontend to the backend. It refactors the ORCID integration to proxy requests through a new Laravel controller instead of making direct API calls from Vue components.
Key Changes:
- Created a new backend proxy controller to handle ORCID API requests server-side
- Refactored Vue components to use the new backend endpoints instead of direct ORCID API calls
- Enhanced UI with loading states and improved error handling
- Consolidated ORCID configuration into a dedicated config file
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| routes/web.php | Adds three new ORCID routes for search, person, and employment endpoints |
| app/Http/Controllers/OrcidController.php | New controller that proxies requests to the ORCID API |
| config/orcid.php | New configuration file for ORCID API URLs |
| resources/js/Shared/SelectOrcidId.vue | Refactored to call backend endpoints, improved error handling and state management |
| resources/js/Pages/Console/Users/Partials/UserProfile.vue | Added loading states and validation for ORCID search |
| resources/js/Pages/Auth/Register.vue | Added loading states and validation for ORCID search |
| app/Support/Csp/Policies/NmrxivPolicy.php | Removed ORCID from CSP since requests now go through backend |
| app/Http/Middleware/HandleInertiaRequests.php | Removed ORCID API URLs from shared Inertia props |
| .env.example | Consolidated three ORCID env vars into one base URL |
| .env.ci | Consolidated three ORCID env vars into one base URL |
vcnainala
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes: