Make cert expiration check independent of locale #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Please wait with reviewing since I could only change the checks for the CA cert for now. |
Member
Author
|
@danopt you found an alternative way to deal with the locale in the function. Let's try that because it needs less changes than my approach. |
…emented to_datetime_by_locale filter
This reverts commit ade949e.
martialblog
reviewed
Apr 17, 2023
Member
martialblog
left a comment
martialblog
left a comment
There was a problem hiding this comment.
For this amount of code I usually recommend some unit tests... but overall, looks good.
Contributor
|
Yes, unit tests are probably a good idea. I will implement them. |
martialblog
approved these changes
Apr 28, 2023
Member
martialblog
left a comment
martialblog
left a comment
There was a problem hiding this comment.
Looks good from the Python Point-Of-View. Ansible part I assume works
Very good work! ⭐
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
* Fix pipelines.yml comments fixes NETWAYS#125
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
This will use another module for checking expiration dates of certificates fixes NETWAYS#124 --------- Co-authored-by: Daniel Patrick <daniel.patrick@netways.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use another module for checking expiration dates of certificates
fixes #124