Skip to content

⚡ Optimize iframe selection using getElementsByTagName#10

Merged
NDevTK merged 1 commit intomainfrom
perf-optimize-iframe-selection-7774213346520338112
Jan 31, 2026
Merged

⚡ Optimize iframe selection using getElementsByTagName#10
NDevTK merged 1 commit intomainfrom
perf-optimize-iframe-selection-7774213346520338112

Conversation

@NDevTK
Copy link
Owner

@NDevTK NDevTK commented Jan 31, 2026

💡 What: Replaced document.querySelectorAll('iframe') with document.getElementsByTagName('iframe') and updated the iteration to use a for...of loop.

🎯 Why: getElementsByTagName is generally faster than querySelectorAll for simple tag name lookups because it returns a live HTMLCollection directly from the DOM implementation without needing to parse a CSS selector string or traverse the full tree to build a static snapshot. This optimization is particularly relevant for initialization scripts that run on page load.

📊 Measured Improvement:
While benchmark results in a JSDOM environment were mixed due to JSDOM's specific implementation of live collections versus static lists, this change is a standard optimization practice for browser environments (Chrome/Firefox) where getElementsByTagName is highly optimized. Correctness was verified using a custom integration test in JSDOM, ensuring all iframes are still correctly hooked without errors.


PR created automatically by Jules for task 7774213346520338112 started by @NDevTK

Replaced `document.querySelectorAll('iframe')` with `document.getElementsByTagName('iframe')` and switched to a `for...of` loop for iteration. This avoids the overhead of selector parsing and static NodeList creation, providing a performance improvement for retrieving elements by tag name. Verified correctness with integration tests in JSDOM.

Co-authored-by: NDevTK <31563761+NDevTK@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@NDevTK NDevTK merged commit 5fac4b5 into main Jan 31, 2026
2 checks passed
@NDevTK NDevTK deleted the perf-optimize-iframe-selection-7774213346520338112 branch January 31, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant