Support using other session objects e.g. requests_cache#13
Open
ValueRaider wants to merge 2 commits intoNDelventhal:mainfrom
Open
Support using other session objects e.g. requests_cache#13ValueRaider wants to merge 2 commits intoNDelventhal:mainfrom
ValueRaider wants to merge 2 commits intoNDelventhal:mainfrom
Conversation
Refactor cot_reports.py to put functions in new class with session property. User API not changed - original functions simply pass-through to class instance. New API function 'set_session', for user to pass through a different session object.
Author
|
@NDelventhal Can you review & merge? I have plans for a bigger PR next - file caching & data cleaning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
cot_reports.pyto put functions in new class with session property.User API not changed - original functions simply pass-through to class instance.
New API function
set_session, for user to pass through a different session object - example in README.