Skip to content

Convert model-released to new enum and use in api.#967

Merged
gunnarvelle merged 9 commits into
masterfrom
feat/use-enums-in-apis
Jun 1, 2026
Merged

Convert model-released to new enum and use in api.#967
gunnarvelle merged 9 commits into
masterfrom
feat/use-enums-in-apis

Conversation

@gunnarvelle
Copy link
Copy Markdown
Member

Bedre validering av model-released verdier.

@gunnarvelle gunnarvelle requested a review from a team May 21, 2026 10:07
Copy link
Copy Markdown
Contributor

@amatho amatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi kan vel også bruke enum-en direkte i modelRelease i V2 og V3 DTO-ene for ImageMetaInformation, slik som med aiGenerated?

Comment thread image-api/src/main/scala/no/ndla/imageapi/service/ConverterService.scala Outdated
@gunnarvelle gunnarvelle requested review from a team and amatho May 21, 2026 12:34
Comment thread image-api/src/main/scala/no/ndla/imageapi/service/WriteService.scala Outdated
@gunnarvelle gunnarvelle requested a review from jnatten May 27, 2026 07:49
@gunnarvelle gunnarvelle force-pushed the feat/use-enums-in-apis branch 2 times, most recently from b35516f to 0f480f6 Compare May 28, 2026 12:45
@gunnarvelle gunnarvelle requested a review from a team May 28, 2026 12:52
@gunnarvelle gunnarvelle force-pushed the feat/use-enums-in-apis branch from 0f480f6 to 12dd2a8 Compare June 1, 2026 06:17
@jnatten
Copy link
Copy Markdown
Contributor

jnatten commented Jun 1, 2026

Testa denne nå og den ser fin ut for meg, men det @amatho sier hadde jo vært nice så doc'en sier hva som kan komme ut istedenfor bare string?

@gunnarvelle
Copy link
Copy Markdown
Member Author

gunnarvelle commented Jun 1, 2026

Testa denne nå og den ser fin ut for meg, men det @amatho sier hadde jo vært nice så doc'en sier hva som kan komme ut istedenfor bare string?

Det gjør jo det. Måtte berre kjøre generateTypescript, men det hadde jo blitt kjørt ved merge uansett. Skjønner. Fikser.

@gunnarvelle
Copy link
Copy Markdown
Member Author

Bedre no @jnatten og @amatho ?

@gunnarvelle gunnarvelle merged commit 8b07d25 into master Jun 1, 2026
7 checks passed
@gunnarvelle gunnarvelle deleted the feat/use-enums-in-apis branch June 1, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants