ci(release): recompute evidence digest at tag time; adopt shared-CI 0.8.1#14
Merged
Merged
Conversation
….8.1 Harden the tag-time release-evidence gate and consume the shared supply-chain permission fix. - Verify release-evidence bundle: recompute setup_digest from the tagged tree (git ls-files -s, excluding the bundle) and fail closed on any mismatch, so the public release control point — not only the private harness — binds the bundle to the exact released content. Also enforce freshness (generated <= now < expires) and structural completeness (vendor, platforms, non-empty checks). - Re-pin all shared nddev-ci-workflows callers 0.7.0 -> 0.8.1 (eda8ff7 -> 8b8e3ea). - Grant artifact-metadata: write on the publish job so the attest jobs' new required scope (0.8.1 #13) is present through the caller ceiling. - Regenerate build/release-evidence.json for the new content digest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Independent verification of two confirmed findings against ground truth:
Verify release-evidence bundlestep checked the digest format but never recomputed it from the tagged tree, and enforced no freshness/completeness. The strong content-recompute lived only in the private harness, which the public tag-push path never runs — so the release control point could not prove the bundle bound to the released content.nddev-ci-workflowsadvanced0.7.0 → 0.8.1; feat(release): publish the minimal runtime bundle as a second asset #13 (0a059bc) added theartifact-metadata: writescope the attest jobs require (actions/attestv4.1.1). This repo was still pinned to0.7.0/eda8ff7, and the publish caller did not grant that scope (reusable-workflow permissions intersect with the caller ceiling).What
Verify release-evidence bundle: recomputesetup_digestfromgit ls-files -s(excluding the bundle itself — identical toscripts/evidence.compute_setup_digest) and fail closed on mismatch; enforce freshness (generated <= now < expires) and structural completeness (vendor,platforms, non-emptychecks).0.7.0 → 0.8.1(eda8ff7 → 8b8e3ea).artifact-metadata: writeon thepublishjob.build/release-evidence.jsonso its digest matches the new content.Verification
actionlintclean on all changed workflows.compute_setup_digest(sha256:1868c895…);emit_evidence.py --checkvalid.workflow_callinput changed0.7.0↔0.8.1(interface-compatible; only the additive permission + a Syft bump + a SLSA label edit).Harness pin advance + contract-test updates follow in
nddev-harnesses.