kelly code review #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeerika
reviewed
Aug 7, 2020
Comment on lines
+14
to
+17
| # abstract: a number of the borehole | ||
| doc$dataset$abstract <- gsub("\\(C43-MS1\\)", "borehole with number C43-MS1", doc$dataset$abstract) | ||
| doc$dataset$abstract <- gsub("45 km", "45 kilometers (km)", doc$dataset$abstract) | ||
| doc$dataset$abstract <- gsub("5.2 m", "5.2 meters (m)", doc$dataset$abstract) |
There was a problem hiding this comment.
didn't know you could use this to achieve this! I usually use the web editor or str_replace but this is a good way too!
There was a problem hiding this comment.
when I know both I get confused between gsub and str_replace because the two has the order of the arguments in slightly different positions (pattern first or string first)
| # resource_map_pid = pkg$resource_map, | ||
| # data_pids = pkg$data, | ||
| # metadata_path = eml_path, | ||
| # public = FALSE) |
There was a problem hiding this comment.
nice! everything looks very similar to how I would achieve these tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kelly's code for ticket #20632