Skip to content

Conversation

@clarinnancy
Copy link

Hi Jeanette, here is the code I used to convert the excel file to csv in the Hamilton ticket.

Copy link
Contributor

@jeanetteclark jeanetteclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very simple code (thankfully it is a clean dataset!) but I ran it and the result looks good.

I added some best-practices type recommendations but otherwise this looks good (and the resulting file also looks good)

@@ -0,0 +1,3 @@
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should always include your library calls (package dependencies) at the top of every R script that you write. This way your code is more reproducible (you can run this script on its own) and other people can run it easily

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally - I would fix the (1) on your filenames. It is not good practice to name files with spaces and parentheses (even if you downloads folder does it for you all the time). I always am in the practice of renaming files once I upload them onto the server.

@@ -0,0 +1,3 @@
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")
library(readxl)
slx <- read_excel("/home/clarinnancy/tickets/Hamilton2016/Alaska_place_time_16b (1).xls")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants