Remove try blocks that make debugging harder #180
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These try blocks catch all the exceptions and report them to the logger, but I'm pretty sure that will happen anyway. By doing this, they get rid of the line-number information that would help debug what is causing the errors.
gaurav
changed the title
gaurav
added a commit
that referenced
this pull request
Apr 21, 2025
This is to track how quickly NodeNorm normalizes identifiers, and also which identifiers are being normalized as per #277 (comment). Also removed some unnecessary catch-everything blocks as per #180.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These try blocks catch all the exceptions and report them to the logger, but I'm pretty sure that will happen anyway. By doing this, they get rid of the line-number information that would help debug what is causing the errors. Try blocks that catch exceptions and change the return value have been left untouched.
WIP: need to test this out and make sure this approach makes sense.