Skip to content

Adding a Github Action that runs on CIRRUS runner scale sets and NCAR HPC containers#1071

Merged
hkershaw-brown merged 1 commit into
mainfrom
cirrus_actions
May 15, 2026
Merged

Adding a Github Action that runs on CIRRUS runner scale sets and NCAR HPC containers#1071
hkershaw-brown merged 1 commit into
mainfrom
cirrus_actions

Conversation

@mjs2369
Copy link
Copy Markdown
Contributor

@mjs2369 mjs2369 commented Mar 9, 2026

Description:

Adds a Github Action that runs Lorenz_96 on CIRRUS runner scale sets and NCAR HPC containers. Runs with all mpi options (mpi, mpif08, nompi) with the compilers gfortran, and nvhpc, and intel-oneapi.

Note that this action will be run on every pull request but will NOT be required to pass to merge into main. @hkershaw-brown I do not have the permission to change these settings in the DART repo, if you could please ensure this is correctly set.

Fixes issue

No issue in for this, woops

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Updated developer's guide documentation.

Tests

Please describe any tests you ran to verify your changes.

Tested action on push, all jobs succeeded.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown
Copy link
Copy Markdown
Member

@mjs2369 Hey Marlee when you update this with main can you rebase rather than merge. Because we will probably want to squash commits testing the actions. Cheers,
Helen

Comment thread .github/actions/build_run_model/action.yml Outdated
Comment thread .github/workflows/cirrus_action_on_pull_request.yml Outdated
Comment thread .github/workflows/cirrus_action_on_pull_request.yml Outdated
@mjs2369 mjs2369 force-pushed the cirrus_actions branch 3 times, most recently from 5def75b to be49488 Compare March 9, 2026 19:49
@hkershaw-brown
Copy link
Copy Markdown
Member

This is really cool, I think this can be a matrix of compiler, mpi
This is a quick sketch: cirrus_actions...cirrus_actions-matrix
Note not tested, but I think if this action can be matrixized (?) then adding cce, ifx, lfortran, whatever compiler will be easier in the future.

@hkershaw-brown
Copy link
Copy Markdown
Member

Any update on why all the CIRRUS runners are failing?

@mjs2369
Copy link
Copy Markdown
Contributor Author

mjs2369 commented Mar 16, 2026

Any update on why all the CIRRUS runners are failing?

@hkershaw-brown yes, I just heard back from Ben Kirk. The cause is currently unknown, but is definitely on the CIRRUS-side and has been reported to the CIRRUS admins. There is currently no timeline for the fix, but I will run the final tests with the matrix as soon as I get the go-ahead.

@hkershaw-brown
Copy link
Copy Markdown
Member

Note on feedback to GitHub on ❌ vs ⚠️
https://github.com/orgs/community/discussions/35424

@hkershaw-brown hkershaw-brown self-requested a review March 27, 2026 16:26
Copy link
Copy Markdown
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this on 'request changes'.
Needs CIRRUS to be online 🤦‍♀️ to test
rebase (squash) commits into a single commit before merging.

@hkershaw-brown
Copy link
Copy Markdown
Member

Is CIRRUS still down?

@mjs2369
Copy link
Copy Markdown
Contributor Author

mjs2369 commented Apr 13, 2026

@hkershaw-brown yep, chatted with Ben at the conference too and there's currently no timeline. Should we put this on draft in the mean time?

@hkershaw-brown
Copy link
Copy Markdown
Member

@hkershaw-brown yep, chatted with Ben at the conference too and there's currently no timeline. Should we put this on draft in the mean time?

well, that is less than ideal.

@hkershaw-brown hkershaw-brown marked this pull request as draft April 13, 2026 17:23
@hkershaw-brown
Copy link
Copy Markdown
Member

I'm rebasing this to be up-to-date with main, watch out when you pull.

Comment thread .github/actions/build_run_model/action.yml Outdated
@mjs2369 mjs2369 force-pushed the cirrus_actions branch 2 times, most recently from 4d076a1 to b1a2f7f Compare May 6, 2026 19:01
@mjs2369 mjs2369 marked this pull request as ready for review May 6, 2026 19:07
@mjs2369 mjs2369 requested a review from hkershaw-brown May 6, 2026 19:08
@hkershaw-brown
Copy link
Copy Markdown
Member

@mjs2369 can you rebase this so it is just a single commit (rather than two commits, code & merge commit with main).

@mjs2369 mjs2369 force-pushed the cirrus_actions branch 2 times, most recently from a968023 to ac0ad8e Compare May 6, 2026 21:52
… with all mpi options and gfortran, nvhpc, intel-oneapi
@mjs2369
Copy link
Copy Markdown
Contributor Author

mjs2369 commented May 6, 2026

@hkershaw-brown done

@hkershaw-brown hkershaw-brown added the release! bundle with next release label May 7, 2026
Copy link
Copy Markdown
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice Marlee, great work on all the container and cirrus interactions.

I'd like to bundle this with the next release, next week (when I am back in the office).

@hkershaw-brown merge this before #1069

@hkershaw-brown hkershaw-brown merged commit b2c19a8 into main May 15, 2026
13 checks passed
@hkershaw-brown hkershaw-brown deleted the cirrus_actions branch May 18, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release! bundle with next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants