Draft
Conversation
AdriaBarbecho
commented
Mar 18, 2026
AdriaBarbecho
commented
- Tag issue being addressed
- Add tests
- Update docstrings/documentation, if applicable
- Update changelog
- All tests successfully pass
Release of peleffy 1.5.2
…penff toolkit and forcefields. The simtk (package managing the physical magnitudes) is migrated to the newest version, used in the new versions of the toolkits.
…newer versiond of openff
martimunicoy
requested changes
Mar 20, 2026
| - rdkit | ||
| - openff-toolkit==0.10.7 | ||
| - openff-forcefields==2023.05.1 | ||
| - openff-toolkit |
There was a problem hiding this comment.
It is better to freeze the version of openff to prevent any issues with next versions that they release. I would check which is the latest one, run the tests with it and freeze that version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.