Skip to content

fix: preserve all dates for non-periodic datasets with summaries.datetime#1967

Merged
dzole0311 merged 1 commit intomainfrom
fix-datasets-with-non-periodic-collections
Jan 29, 2026
Merged

fix: preserve all dates for non-periodic datasets with summaries.datetime#1967
dzole0311 merged 1 commit intomainfrom
fix-datasets-with-non-periodic-collections

Conversation

@dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented Jan 29, 2026

Closes: #1966

Description of Changes

  • Fix regression where non-periodic datasets with discrete dates in summaries.datetime only show the first 2 dates in the timeline instead of all dates
  • Skip normalizeDomain() for non-periodic data when domain has >2 discrete dates from summaries.datetime

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

@netlify
Copy link

netlify bot commented Jan 29, 2026

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 75f8ce6
🔍 Latest deploy log https://app.netlify.com/projects/veda-ui/deploys/697b16bad11b4700089a18e9
😎 Deploy Preview https://deploy-preview-1967--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dzole0311 dzole0311 requested a review from slesaad January 29, 2026 08:19
@dzole0311
Copy link
Collaborator Author

@slesaad in my test PR to veda-config-ghg, you'll notice I updated a few package.json paths to match the restructured veda-ui.

Once the fix here is merged in veda-ui and released, we’ll need to apply the same path updates in the veda-ui bump PR for veda-config-ghg.

Also, can this wait for Monday’s release or do we need hotfix today?

@slesaad
Copy link
Member

slesaad commented Jan 29, 2026

thanks for fixing this! @dzole0311 !

@dzole0311 dzole0311 merged commit 2933cfd into main Jan 29, 2026
11 checks passed
@dzole0311 dzole0311 deleted the fix-datasets-with-non-periodic-collections branch January 29, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Datasets with non periodic collections fail generating all the relevant dates in the timeline

2 participants