Ensure blank sequence opened on new page shows correct right side tabs#1924
Ensure blank sequence opened on new page shows correct right side tabs#1924AaronPlave wants to merge 8 commits into
Conversation
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
requested review from
dandelany
and removed request for
joswig and
mattdailis
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
👍 looks good, tested locally
dandelany
force-pushed
the
fix/default-sequence-file-tab-fix
branch
from
d5ced45 to
09978e2
Compare
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Deferring this for now since it's stuck on an e2e test failure and not an obvious fix. Something is causing the "Cancel discards user metadata changes" test to fail - I fixed one issue but now it's complaining about a button not being clickable and I can't figure out why without a deep dive... @AaronPlave can you take a look tomorrow?
AaronPlave
force-pushed
the
fix/default-sequence-file-tab-fix
branch
from
e7d5dd6 to
34f95b8
Compare
|
@dandelany tests passing |
| $: activeFileIsSequence = | ||
| $activeDocumentPath === null || | ||
| ($activeDocument.type !== null && $activeDocument.type === WorkspaceContentType.Sequence); | ||
| $: selectedFileIsSequence = |
There was a problem hiding this comment.
per discussion with @AaronPlave - we are OK with the logic but not the names - consider renaming this one to activeFileIsSequence and the one above to activeFileIsSequenceOrDraft or similar. Or make a separate activeFileIsDraft but this may be more work.
Also - add let for whatever variables we choose
There was a problem hiding this comment.
Refactored, take another look.
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
2 participants
This fixes the issue where the selected command and command dictionary right side tabs were not being shown after workspace page load with no file in the url (blank sequence)