Activity Directive Builder by JosephVolosin · Pull Request #1900 · NASA-AMMOS/plandev-ui

JosephVolosin · 2026-03-27T13:41:58Z

This PR introduces the activity directive builder, modeled from the activity filter builder for timeline editing, to build an activity directive prior to actual creation on the timeline.

The builder can be accessed 3 different ways:

Dragging & dropping an activity on the timeline now brings up the builder prior to creation
Hovering over an activity type on the Activity, Resource, Event Types menu allows the user to click the '+' button which brings up the builder
Clicking the '+' button next to upload and filter underneath Activity, Resource, Event Types

The directive builder allows the user to fill in a name, start time, and parameter values for a directive prior to having it created on the timeline. Validation for parameter values and missing required parameters is included, but the user is still able to create an 'invalid' directive if they wish.

Testing

Create a plan and choose any of the 3 ways from above to access the directive builder. Then, fill out the information in the builder and click 'Create'. The activity directive with all the entered information should appear on the timeline.

AaronPlave · 2026-03-27T14:40:22Z

Any reason not to use the activity form here embedded in a draggable window with a few extra components thrown in on top?

JosephVolosin · 2026-04-24T17:17:48Z

Any reason not to use the activity form here embedded in a draggable window with a few extra components thrown in on top?

It seemed like it would be a considerable rework to support it here since we want the validation and editing to happen on a directive that isn't created. The code for validation is more-or-less copy/paste though, so at least I think that can be pulled out to a common function.

AaronPlave · 2026-05-11T21:29:58Z

+  import Parameters from '../parameters/Parameters.svelte';
+  import Draggable from '../timeline/form/TimelineEditor/Draggable.svelte';
+
+  export let directiveWidth: number = 1000;


Maybe just width? Know the other ones say "filterWidth" though hoping at some point we can merge #1828 and make that width more generic if it isn't already included in there,

AaronPlave · 2026-05-11T21:31:33Z

      }
      const activityDirectiveTags: ActivityDirectiveTagsInsertInput[] = tagsToAdd.map(({ id: tag_id }) => ({
        directive_id: activityDirective.id,
+


whitespace change not needed

AaronPlave · 2026-05-11T21:35:55Z

@@ -760,7 +761,7 @@

          const createActivities = () => {
            items.forEach(item => {


Only one buildDirective can win here so all previous dispatches will be lost. This PR is centered around a single builder window for a single directive and I don't think we want to go near a multi-directive builder here but it does break the previous behavior where a user could drag all activity types on the timeline via the handle to the right of the "Activities (X)" header. I doubt anyone was actually using this feature, it's likely more for testing purposes and it is pretty hidden. Should either directly create all of those directives and skip the builder, open the builder with the first type, or get rid of the handle entirely.

AaronPlave · 2026-05-11T21:38:03Z

+
+  function onCreateActivityDirective(directive: ActivityDirectiveInsertInput) {
+    if ($plan !== null && $plan.model) {
+      effects.createActivityDirectivePredefined(directive, $plan, user);


Should we await creation of the directive first in case it fails to create? I know a failure toast will appear, just means that if any sort of hiccup happens (unlikely) that user input from builder will be lost. Not sure if it is necessary though.

AaronPlave · 2026-05-11T21:38:23Z

    >
      <UploadIcon />
    </button>
+    <Button variant="ghost" size="icon-sm" aria-label="Add Activity" on:click={onShowDirectiveBuilder}>


Button needs permission gating.

AaronPlave · 2026-05-11T21:38:40Z

    >
      <UploadIcon />
    </button>
+    <Button variant="ghost" size="icon-sm" aria-label="Add Activity" on:click={onShowDirectiveBuilder}>


Could this be an outline button that matches the height of the neighboring buttons?

AaronPlave · 2026-05-11T21:40:20Z

+              </div>
+            </div>
+            <div class="directive-section-content directive-section-content-bordered">
+              <DatePickerField


Would be nice to use plan start/end instead of today for the buttons here (think we do it in other places in the app) to make it easier for users to get back to a relevant time range.

AaronPlave · 2026-05-11T22:05:19Z

+                {/if}
+              </div>
+            </div>
+            <!-- </CssGrid> -->


Unused comment

AaronPlave · 2026-05-11T22:06:12Z

+  let startTimeField: FieldStore<string>;
+  let startTime: string = $plan?.start_time_doy ?? '';
+
+  let currentActivityTypeFormParams: FormParameter[] = [];


Can you alphabetize your let declarations in this component?

AaronPlave · 2026-05-11T22:06:26Z

+  }
+
+  .body {
+    /* background: var(--st-gray-15); */


Can remove this comment

AaronPlave · 2026-05-11T22:06:53Z

  return result;
 }
+
+export async function validateArguments(


Can you add unit tests for this?

AaronPlave · 2026-05-11T22:08:30Z

Can you add some e2e tests (though I'm sure you're working on those) that use the builder via button and drag and drop?

JosephVolosin temporarily deployed to test-workflow March 27, 2026 13:42 — with GitHub Actions Inactive

JosephVolosin had a problem deploying to test-workflow April 16, 2026 14:18 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow April 23, 2026 18:39 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from d91262a to cd6b8e4 Compare April 23, 2026 18:41

JosephVolosin had a problem deploying to test-workflow April 23, 2026 18:41 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from cd6b8e4 to 157b1cc Compare April 23, 2026 18:42

JosephVolosin had a problem deploying to test-workflow April 23, 2026 18:42 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from 157b1cc to b060112 Compare April 23, 2026 20:24

JosephVolosin had a problem deploying to test-workflow April 23, 2026 20:24 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from b060112 to 7e23e38 Compare April 23, 2026 20:25

JosephVolosin had a problem deploying to test-workflow April 23, 2026 20:25 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from 7e23e38 to 4e9d584 Compare April 23, 2026 20:34

JosephVolosin had a problem deploying to test-workflow April 23, 2026 20:34 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from 4e9d584 to 1f30961 Compare April 23, 2026 20:45

JosephVolosin had a problem deploying to test-workflow April 23, 2026 20:45 — with GitHub Actions Failure

JosephVolosin force-pushed the feature/directive-creation-modal branch from 1f30961 to 38304f5 Compare April 23, 2026 20:46

JosephVolosin had a problem deploying to test-workflow April 23, 2026 20:46 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow April 24, 2026 15:52 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow April 24, 2026 17:01 — with GitHub Actions Failure

AaronPlave added the feature New feature or request label Apr 28, 2026

JosephVolosin had a problem deploying to test-workflow May 7, 2026 20:12 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 7, 2026 20:49 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 7, 2026 20:54 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 7, 2026 20:56 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 8, 2026 14:26 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 8, 2026 15:07 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 8, 2026 16:25 — with GitHub Actions Failure

JosephVolosin had a problem deploying to test-workflow May 8, 2026 16:35 — with GitHub Actions Failure

JosephVolosin added 8 commits May 8, 2026 12:35

Create Actiity Directive Builder

f40cdc4

Add directive builder to drag & drop

5e56681

Linting, add start time set during drag & drop

1a8351b

Initial call of validateArguments when type is selected

5527ef5

Use common function for validateArguments

eff85d5

Log cleanup

d67c3f5

Linting

0456b15

Show missing required parameters

cb284a8

JosephVolosin force-pushed the feature/directive-creation-modal branch from b05e206 to cb284a8 Compare May 8, 2026 16:35

JosephVolosin had a problem deploying to test-workflow May 8, 2026 16:35 — with GitHub Actions Failure

JosephVolosin marked this pull request as ready for review May 8, 2026 16:38

JosephVolosin requested a review from a team as a code owner May 8, 2026 16:38

JosephVolosin requested review from duranb, joswig and mattdailis May 8, 2026 16:38

JosephVolosin had a problem deploying to test-workflow May 8, 2026 17:05 — with GitHub Actions Failure

AaronPlave reviewed May 11, 2026

View reviewed changes

AaronPlave requested changes May 11, 2026

View reviewed changes

		@@ -760,7 +761,7 @@

		const createActivities = () => {
		items.forEach(item => {

Conversation

JosephVolosin commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

AaronPlave commented Mar 27, 2026

Uh oh!

JosephVolosin commented Apr 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JosephVolosin commented Mar 27, 2026 •

edited

Loading