Skip to content

[Breaking Change] Update return type of get_resource_samples #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mythicaeda wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Breaking Change] Update return type of get_resource_samples #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/aerie_cli/aerie_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,8 @@ def exec_sim_query():
sim_dataset_id = resp["simulationDatasetId"]
return sim_dataset_id

def get_resource_timelines(self, plan_id: int):
samples = self.get_resource_samples(self.get_simulation_dataset_ids_by_plan_id(plan_id)[0])
api_resource_timeline = ApiResourceSampleResults.from_dict(samples)
return api_resource_timeline
def get_resource_timelines(self, plan_id: int, state_names: List=None):
return self.get_resource_samples(self.get_simulation_dataset_ids_by_plan_id(plan_id)[0], state_names)

def get_resource_samples(self, simulation_dataset_id: int, state_names: List=None):
"""Pull resource samples from a simulation dataset, optionally filtering for specific states
Expand Down Expand Up @@ -518,9 +516,7 @@ def get_resource_samples(self, simulation_dataset_id: int, state_names: List=Non
raise ValueError(f"Unknown resource profile type: {profile_type}")

resources[name] = values
return {
"resourceSamples": resources
}
return ApiResourceSampleResults.from_dict({"resourceSamples": resources})

def get_simulation_results(self, sim_dataset_id: int) -> str:

Expand Down