fix empty directive name

[bradNASA]

Theresa's suggested fix for using the directive type also as the directive name when name is empty for plan uploads.

[joshhaug]

Presumably this would mean that a directive with name == "" is not treated the same as a blank field.

[cartermak]

@joshhaug My thought too. I'd like that we can preserve an empty name, and only a None gets turned into the activity type name?

[joshhaug]

Discussed with Brad. If an empty string is specified as a directive name, it can cause issues in the timeline in 2.12.

[joshhaug]

@cartermak just saw your comment but not sure I understand your question. It looks like there is an issue in 2.12 that causes name=="" to prevent activities from appearing on the timelines.

[cartermak]

Is this a bug or an expected behavior? If this is a bug, and an empty name should generally be acceptable, then I think Aerie-CLI should support it and I expect Aerie would resolve. If an empty name is not allowed, then I might argue for explicit handling of that case on the client side (e.g., report an error) instead of defaulting to a behavior like automatically assigning a name.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bradNASA]

Is this a bug or an expected behavior?

I think the fix changes the default name for a new directive from "" to None. If the name is specified, then the default doesn't apply. Given the possible interpretation discussed above, it seems preferable for the default to be None instead of "". As it is, it seems like a bug or an ungraceful way of handling a missing directive name.