Methods to add tags for scheduling goals and expansion rules#119
Open
zgoldberg22 wants to merge 2 commits intodevelopfrom
Open
Methods to add tags for scheduling goals and expansion rules#119zgoldberg22 wants to merge 2 commits intodevelopfrom
zgoldberg22 wants to merge 2 commits intodevelopfrom
Conversation
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
cartermak
reviewed
Jan 29, 2024
src/aerie_cli/aerie_client.py
Outdated
| } | ||
| """ | ||
|
|
||
| #add tag to scheduling goal |
Member
There was a problem hiding this comment.
Suggested change
| #add tag to scheduling goal | |
| #add tag to expansion rule |
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
zgoldberg22
temporarily deployed
to
integration-test-workflow
GitHub Actions
Inactive
cartermak
requested changes
Jan 29, 2024
| tag_id=self.get_tag_id_by_name(tag_name) | ||
| ) | ||
|
|
||
| return resp['returning'][0] |
Member
There was a problem hiding this comment.
Suggested change
| return resp['returning'][0] | |
| return resp['returning'][0]["tag_id"] |
| tag_id=self.get_tag_id_by_name(tag_name) | ||
| ) | ||
|
|
||
| return resp['returning'][0] |
Member
There was a problem hiding this comment.
Suggested change
| return resp['returning'][0] | |
| return resp['returning'][0]["tag_id"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods
add_expansion_rule_tagandadd_scheduling_goal_tagas standalone methods to add tags to each component.