A large number of small changes to improve readability and maintainability #28

Open

kwhitefoot wants to merge 104 commits into

N0ury:masterfrom

kwhitefoot:master

Commits on Oct 24, 2016

Commits on Oct 26, 2016

Reformatted all files to get consistent indentation, etc.
kwhitefoot
committed

Commits on Nov 2, 2016

Corrected Accont -> Account.
kwhitefoot
committed

Commits on Nov 4, 2016

Added proto and acceptcrt properties to Security enum so that there is no longer a need for a switch statement to find them.
kwhitefoot
committed

Commits on Nov 5, 2016

Folder override can never be null so do not check for it.
kwhitefoot
committed

Commits on Nov 6, 2016

Commits on Nov 8, 2016

Commits on Nov 9, 2016

Commits on Nov 10, 2016

Removed unused constructor from Sticky.
kwhitefoot
committed

Commits on Nov 11, 2016

Commits on Nov 12, 2016

Commits on Nov 13, 2016

Commits on Nov 14, 2016

Commits on Nov 15, 2016

Commits on Nov 16, 2016

Commits on Nov 17, 2016

Renamed SyncAdapter.context to applicationContext to make it clear that the singleton app context is required here. Renamed accountname to accountName.
kwhitefoot
committed

Commits on Nov 18, 2016

Use constants for column names instead of literal strings.
kwhitefoot
committed

Commits on Nov 27, 2016

Acted on and suppressed some probable bugs reported by the analyser.
kwhitefoot
committed

Commits on Nov 28, 2016

Commits on Nov 29, 2016

Split GetOneNote into SaveNote and SaveNoteAndUpdatDatabase so that we do not need the updateDB argument. This argument was a literal in all calls which means that the caller already knew statical…
kwhitefoot
committed

Commits on Dec 1, 2016

Commits on Dec 3, 2016

Commits on Dec 19, 2016

Commits on Dec 29, 2016

Commits on Jan 4, 2017

Now using wasabeef rich editor in master. Seems to work so far. Need to get rid of the Sticky note stuff as it no longer makes sense.
kwhitefoot
committed

Commits on Jan 18, 2017

Commits on Jan 19, 2017

Commits on Jan 22, 2017

Added icons for the wasabeef rich text editor. Thank you nbenm for point out the problem.
kwhitefoot
committed

Commits on Jan 27, 2017

Fixed typo in SQL create table that was causing an uncaught exception and a strange error in the logcat, See http://stackoverflow.com/questions/2850573/activity-has-leaked-window-that-was-original…
kwhitefoot
committed

Commits on Feb 9, 2017

Added new constructor to ImapNotes2Account to avoid using setters. Removed imapnotes2Account field from ImapNotes2 class because it was only used in one call so it can be local to the caller.
kwhitefoot
committed

Commits on Feb 14, 2017

Added note about travis.
kwhitefoot
authored

Commits on Feb 15, 2017

Commits on Feb 16, 2017

Commits on Feb 17, 2017

Fixed bug in GetSynchronizationInterval, forgot to set status = true on success.
kwhitefoot
committed

Commits on Feb 18, 2017

Replace syncinterval textview with a number picker and removed validation because it is now not possible for it to be invalid.
kwhitefoot
committed

Commits on Feb 20, 2017

Added notes on device id, started implementing device id. Removed unnecessary getter, use final field instead.
kwhitefoot
committed

Commits on Feb 25, 2017

Fixed device id generator bug.
kwhitefoot
committed