fix: Reinstate the filename format setting#128
Open
dzx-dzx wants to merge 2 commits intoMyzel394:masterfrom
Open
fix: Reinstate the filename format setting#128dzx-dzx wants to merge 2 commits intoMyzel394:masterfrom
dzx-dzx wants to merge 2 commits intoMyzel394:masterfrom
Conversation
Owner
|
Thank you for the fix! The PR looks good, I'll need to test it and then we can merge this.
I think I wanted to do a check indeed, but seems like I haven't added that yet. Thanks for pointing me to this |
Author
|
Umm...Would you consider reviewing this PR in recent days? I must say this is a rather important functionality for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #127
By the way, what does
checkIfOutputAlreadyExistsdo? It doesn't seem to prevent old files with the same name from being overwritten despite this check.