Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-hill-08172a210-290.centralus.5.azurestaticapps.net |
|
@codex make a detailed review of this PR |
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy “Assembly Plan” editor/object type and shifts workflow UI focus to the Transformations panel by expanding the Transformation wizard into a multi-step “Design → Build → Collection → Execute” flow.
Changes:
- Removed the Assembly panel type and Assembly object type from the frontend registries.
- Deleted the Assembly editor panel/wizard implementation.
- Expanded
TransformationWizardwith additional workflow steps and configuration UI (assembly method/compiler/machine selections).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/panels.js |
Removes the Assembly panel type registration. |
frontend/src/objectTypes.js |
Removes the Assembly object type registration. |
frontend/src/components/panels/transformations/TransformationWizard.jsx |
Adds a 4-step transformation workflow UI and build configuration selections. |
frontend/src/components/panels/assembly-editor/AssemblyWizard.jsx |
Deletes the previous Assembly wizard implementation. |
frontend/src/components/panels/assembly-editor/AssemblyPanel.jsx |
Deletes the previous Assembly panel implementation. |
frontend/src/activities.js |
Removes Assembly object type from the Explorer activity’s listed object types. |
Comments suppressed due to low confidence (2)
frontend/src/panels.js:114
- After removing the
AssemblyPlanCreatorpanel type,GiThorHammerappears to be unused in this file. Please remove the unused icon import to avoid dead code and potential lint/build warnings.
Experiment: {
id: "synbio.panel-type.data-collector",
title: "Data Collector",
component: CollectionPanel,
objectTypes: [ ObjectTypes.Experiments.id ],
icon: FcAddDatabase,
frontend/src/objectTypes.js:105
- With the
Assemblyobject type removed, theGiThorHammericon import at the top of this file is now unused. Please remove the unused import to keep the ObjectTypes module clean and avoid lint/build warnings.
subdirectory: "strains",
downloadable: true,
},
Transformations: {
id: "synbio.object-type.transformations",
title: "Transformations",
listTitle: "Transformations",
fileNameMatch: /\.json$/,
icon: GiSewingMachine,
createable: true,
extension: '.json',
subdirectory: "transformations"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13231a1ec1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-hill-08172a210-290.centralus.5.azurestaticapps.net |
|
@codex review |
|
Can you resolve the conflicts Kerem, or is something that you would prefer to do on the hackathon? |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
|
Please, change teh header of the TRANSFORMATIONS tab to BUILDS |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8c18f1a47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| createable: true, | ||
| extension: '.json', | ||
| subdirectory: "transformations" | ||
| subdirectory: "buildPlans" |
There was a problem hiding this comment.
This change stores Build Plans under buildPlans, but OneDrive classification still only recognizes JSON files in other folders and does not map this new directory to synbio.object-type.buildplans (see mapOneDriveItemToObjectType). As a result, Build Plan files created in OneDrive are misclassified and do not show up under the Build Plans object type, so users cannot open them with the Build Plans panel.
Useful? React with 👍 / 👎.
| <Tabs.Tab value={TabValues.ASSEMBLY}>{TabValues.ASSEMBLY}</Tabs.Tab> | ||
| <Tabs.Tab value={TabValues.TRANSFORMATION}>{TabValues.TRANSFORMATION}</Tabs.Tab> | ||
| <Tabs.Tab value={TabValues.PLATING}>{TabValues.PLATING}</Tabs.Tab> |
There was a problem hiding this comment.
The UI renders DNA assembly, transformations, and plating as selectable tabs, but there are no matching Tabs.Panel blocks for those values. Clicking any of these tabs leaves the panel blank, which makes the workflow appear broken until users manually switch back to full build.
Useful? React with 👍 / 👎.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-hill-08172a210-290.centralus.5.azurestaticapps.net |
No description provided.