Fix indentation#155
Open
danielquinn wants to merge 1 commit intoMycroftAI:masterfrom
danielquinn:patch-1
Open
Conversation
The way most of the Python code blocks are written, it looked as though these were functions and not methods of the actual skill. In one case, the indentation was totally off, using only one space.
Contributor
|
Yeah I can see how this is clearer that they are intentionally indented blocks. The escaped parantheses might be left over from our previous documentation platform, or it might have just been me trying to play it safe... either way, I think we can remove them :) Thanks again for all these, once we get a signed CLA I think they can all be merged. |
krisgesling
pushed a commit
that referenced
this pull request
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way most of the Python code blocks are written, it looked as though these were functions and not methods of the actual skill. In one case, the indentation was totally off, using only one space.
There's also a number of cases in this file where
()were escaped as\(\)even though this isn't necessary in Markdown unless they're following a]character. Still, I didn't want to remove them in case there was some other reason for this that I don't know about.