Fix issue with pinging multiple subscribers#4
Open
OliveiraHermogenes wants to merge 1 commit intoMxMarx:masterfrom
Open
Fix issue with pinging multiple subscribers#4OliveiraHermogenes wants to merge 1 commit intoMxMarx:masterfrom
OliveiraHermogenes wants to merge 1 commit intoMxMarx:masterfrom
Conversation
In `load_all`, the `subscribed_users` dictionary should map `subscribing_event` to `user_id`, not the other way around. This was causing errors or `subscribing_event` to show instead of the proper ping when additional user subscribed to a reminder via a thumbs up reaction. It didn't seem to affect reminders with a single subscriber because we have the correct order in line 178.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
load_all, thesubscribed_usersdictionary should mapsubscribing_eventtouser_id, not the other way around.reminder/reminder/db.py
Line 147 in 779ec1f
This was causing errors or
subscribing_eventto show instead of the proper ping when additional users subscribed to a reminder via a 👍 reaction.This mostly didn't affect reminders with a single subscriber because we have the correct order in line 178.
reminder/reminder/db.py
Line 178 in 779ec1f