Skip to content
This repository was archived by the owner on Jan 11, 2024. It is now read-only.

Conversation

@yra242
Copy link

@yra242 yra242 commented Jun 22, 2023

here are 2 created files
edm4hep.txt
lcio.txt

@jmcarcell
Copy link

First of all, all the files that are not the one you made have to be removed from the branch. Then let's give a better name to the modified file like fluka_to_edm4hep.py

@jmcarcell
Copy link

In lcio.txt there are some collections that are not in the edm4hep.txt.
There are no parameters in lcio.txt (at the end of the file) but this may be the conversion LCIO -> EDM4hep, I'm not sure, we should also make sure those are also there

@bartosik-hep
Copy link
Contributor

bartosik-hep commented Jun 22, 2023

I agree with Juan, that the missing parameters in lcio.txt must be a problem of the lcio2edm4hep conversion script. But since it is a separate tool that is not part of this PR, we can investigate it later.
A more relevant issue here is in the edm4hep.txt file, specifically in this part:

std::string parameters
Key                           Value 
--------------------------------------------------------------------------------
FilesPerEvent                 []
InputFiles                    []

There are two problems:

  1. no values are assigned to the FilesPerEvent and InputFiles keys
  2. they are stored in the file as std::string parameters, while in reality they represent integer numbers, and should be visible under the int parameters section.

@jmcarcell it looks like podio detects by itself, which type to use, which apparently doesn't work well with python integer types. Do you have an idea how to force it to use the integer type?

@yra242
Copy link
Author

yra242 commented Jun 29, 2023

testEDM4HEP.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants