You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 11, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, all the files that are not the one you made have to be removed from the branch. Then let's give a better name to the modified file like fluka_to_edm4hep.py
In lcio.txt there are some collections that are not in the edm4hep.txt.
There are no parameters in lcio.txt (at the end of the file) but this may be the conversion LCIO -> EDM4hep, I'm not sure, we should also make sure those are also there
I agree with Juan, that the missing parameters in lcio.txt must be a problem of the lcio2edm4hep conversion script. But since it is a separate tool that is not part of this PR, we can investigate it later.
A more relevant issue here is in the edm4hep.txt file, specifically in this part:
std::string parameters
Key Value
--------------------------------------------------------------------------------
FilesPerEvent []
InputFiles []
There are two problems:
no values are assigned to the FilesPerEvent and InputFiles keys
they are stored in the file as std::string parameters, while in reality they represent integer numbers, and should be visible under the int parameters section.
@jmcarcell it looks like podio detects by itself, which type to use, which apparently doesn't work well with python integer types. Do you have an idea how to force it to use the integer type?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here are 2 created files
edm4hep.txt
lcio.txt