Skip to content

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Sep 15, 2025

add distance to ectresult class

Description

allows for computing various distances between one or a list of ectresult objects via cdist in scipy. may also pass in your own distance function instead.

Motivation and Context

post ect analysis

How has this been tested?

tests to add incompatible shapes, none- case, self distance, and various metrics.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x ] My code follows the code style of this project. (make clean)
  • [ x] I have incremented the version number in the pyproject.toml file.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed. (make tests)

@yemeen yemeen requested a review from lizliz as a code owner September 15, 2025 20:14
Copy link
Contributor

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lizliz lizliz merged commit 734040e into main Sep 16, 2025
3 checks passed
@yemeen yemeen deleted the ect-dist branch September 20, 2025 21:34
@yemeen yemeen mentioned this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants