Skip to content

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Apr 24, 2025

Closes #50

Description

removes parallel flag on compute_shape_descriptor since its just a simple function
and uses numba's list type to fix the deprecation warning on compile


For more information visit https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-reflection-for-list-and-set-types

File "src/ect/ect_graph.py", line 172:
    @njit(parallel=True, fastmath=True)
    def _compute_directional_transform(
    ^

  warnings.warn(NumbaPendingDeprecationWarning(msg, loc=loc))

Motivation and Context

aesthetic

How has this been tested?

ect.calculate(g) runs without warnings

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [ x] My code follows the code style of this project. (make clean)
  • [ x] I have incremented the version number in the pyproject.toml file.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed. (make tests)

@yemeen yemeen requested a review from lizliz as a code owner April 24, 2025 19:33
@lizliz lizliz merged commit afb00a3 into main Apr 25, 2025
3 checks passed
@yemeen yemeen deleted the fix-warnings branch April 25, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

suppress parallel warning when only computing ecc

3 participants