Skip to content

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Mar 13, 2025

rewrites ect class to use vectorized computations and defines ECTResult class to store ect_arrays with plotting capabilities. also adds n-dimensional support

Description

separates concerns from embeddedgraph class and ect class. adds a new directions class for precise direction handling.

ect class now uses directions matrix to project graph coordinates. numba prange is used to make things fast:

      "points_100000_complexity_5": {
        "mean_time": 0.7333681106567382,
        "std_time": 0.011764391608895074,
        "min_time": 0.7214951515197754,
        "max_time": 0.7503418922424316
      }

embeddedgraph now maintains a coord_matrix for easy retrieval.

Motivation and Context

allows for easier extension of code and faster run times.

How has this been tested?

added new tests to handle code structure

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x ] My code follows the code style of this project. (make clean)
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly. (make html)
  • [x ] I have incremented the version number in the pyproject.toml file.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed. (make tests)

@yemeen yemeen linked an issue Mar 13, 2025 that may be closed by this pull request
@yemeen yemeen marked this pull request as ready for review March 30, 2025 19:54
@yemeen yemeen requested a review from lizliz as a code owner March 30, 2025 19:54
Copy link
Contributor

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@lizliz lizliz merged commit fd4605c into main Apr 8, 2025
2 checks passed
@yemeen yemeen deleted the vectorizedect branch April 15, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible duplication

3 participants