Skip to content

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Jan 16, 2025

python-publish workflow shouldn't run when source code doesn't change.

Description

only runs on changes to ect/, setup.py, pyproject.toml.

Motivation and Context

allows branches to merge even if version number isn't bumped for non-package related changes

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (make clean)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (make html)
  • I have incremented the version number in the pyproject.toml file.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (make tests)

@yemeen yemeen requested a review from lizliz as a code owner January 16, 2025 23:07
Copy link
Contributor

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lizliz lizliz merged commit 839579b into main Jan 17, 2025
3 checks passed
@yemeen yemeen deleted the publish-on-src-change branch January 22, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants