Skip to content

Remove testpypi workflow and revert from release based to on main push #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lizliz merged 1 commit into from
Jan 14, 2025
Merged

Remove testpypi workflow and revert from release based to on main push #39

lizliz merged 1 commit into from
Jan 14, 2025

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Jan 14, 2025

apparently testpypi is not advised for CI development. so we should drop it and revert publish-package to work on pushes to main.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@yemeen yemeen requested a review from lizliz as a code owner January 14, 2025 19:51
lizliz
lizliz approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@lizliz lizliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lizliz lizliz merged commit 4d65b0a into main Jan 14, 2025
3 checks passed
@yemeen yemeen deleted the fix-python-publish branch January 14, 2025 20:16
@yemeen yemeen mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizliz lizliz lizliz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yemeen @lizliz