Skip to content

Update nix#212

Merged
sagarpatil-mv merged 3 commits intomainfrom
update-nix
Jan 14, 2026
Merged

Update nix#212
sagarpatil-mv merged 3 commits intomainfrom
update-nix

Conversation

@sagarpatil-mv
Copy link
Copy Markdown
Contributor

@sagarpatil-mv sagarpatil-mv commented Nov 20, 2025

Note

Upgrade and build setup adjustments

  • Bumps nixpkgs pin in flake.lock to 4c8cdd5 (nixos-25.05)
  • Moves openssl and adds perl to compile-time nativeBuildInputs; runtime buildInputs now empty
  • Removes macOS-specific frameworks from previous runtime deps
  • Extends test skips by adding --skip=anonymiser::tests::successfully_truncates

Written by Cursor Bugbot for commit 5f05b6e. Configure here.

- **Nix flake**: Updated to stable `nixos-25.05`

- **Rust version**: Upgraded from 1.78 to 1.91 for test and macOS builds
- **Linux musl build**: Upgraded to 1.90.0 (pinned to `1.90.0-stable-2025-09-27`)
- **OpenSSL**: Added vendored OpenSSL feature to eliminate system dependency issues across muslrust image versions

- Fixed clippy lint `iter_kv_map`
- Removed unused `SaltConfig` struct

- Rust 1.78 is incompatible with `cargo2junit` (requires 1.81+)
- Newer muslrust images had OpenSSL configuration issues
- Aligns CI with local Nix development environment (Rust 1.91) (well close enough for rock n roll ; )
@sagarpatil-mv sagarpatil-mv force-pushed the update-nix branch 2 times, most recently from 49454c0 to fc3f217 Compare January 14, 2026 06:04
- Move openssl to compile-time deps
- Apparently there's a regression in the 25.05 branch from NixOS/nixpkgs#50921
that needs `perl` to also be available at compile-time. The fix goertzenator/nixpkgs@d768208
seems to be missing from the nix file. Not sure why but this setup works!
@sagarpatil-mv sagarpatil-mv marked this pull request as ready for review January 14, 2026 06:16
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

Comment thread flake.nix
@alskipp
Copy link
Copy Markdown
Contributor

alskipp commented Jan 14, 2026

Works for me. But not sure about the rationale of this bit?:

--skip=anonymiser::tests::successfully_truncates

Are these tests unreliable?

Copy link
Copy Markdown
Contributor

@alskipp alskipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sagarpatil-mv sagarpatil-mv merged commit d414a6e into main Jan 14, 2026
7 checks passed
@sagarpatil-mv sagarpatil-mv deleted the update-nix branch January 14, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants