Update nix#212
Merged
sagarpatil-mv merged 3 commits intomainfrom Jan 14, 2026
Merged
Conversation
59f8e08 to
37447ce
Compare
- **Nix flake**: Updated to stable `nixos-25.05` - **Rust version**: Upgraded from 1.78 to 1.91 for test and macOS builds - **Linux musl build**: Upgraded to 1.90.0 (pinned to `1.90.0-stable-2025-09-27`) - **OpenSSL**: Added vendored OpenSSL feature to eliminate system dependency issues across muslrust image versions - Fixed clippy lint `iter_kv_map` - Removed unused `SaltConfig` struct - Rust 1.78 is incompatible with `cargo2junit` (requires 1.81+) - Newer muslrust images had OpenSSL configuration issues - Aligns CI with local Nix development environment (Rust 1.91) (well close enough for rock n roll ; )
49454c0 to
fc3f217
Compare
- Move openssl to compile-time deps - Apparently there's a regression in the 25.05 branch from NixOS/nixpkgs#50921 that needs `perl` to also be available at compile-time. The fix goertzenator/nixpkgs@d768208 seems to be missing from the nix file. Not sure why but this setup works!
fc3f217 to
5f05b6e
Compare
Contributor
|
Works for me. But not sure about the rationale of this bit?: Are these tests unreliable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Upgrade and build setup adjustments
nixpkgspin inflake.lockto4c8cdd5(nixos-25.05)openssland addsperlto compile-timenativeBuildInputs; runtimebuildInputsnow empty--skip=anonymiser::tests::successfully_truncatesWritten by Cursor Bugbot for commit 5f05b6e. Configure here.