Skip to content

Conversation

@milov-dmitriy
Copy link
Collaborator

  • tmpfs: чтобы не хранить данные после запуска тестов
  • volume prune: чтобы очищать volume от неименованных контейнеров
  • kadmin_api depends on kdc: оба этих контейнера создают одну папку, из-за чего возникал race_condition, теперь нет

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses three infrastructure improvements for Docker Compose configurations: fixing a race condition between Kerberos services, preventing test data persistence, and automating volume cleanup.

Changes:

  • Added dependency for kadmin_api on kdc service to resolve race condition on shared volume creation
  • Added tmpfs mounts for PostgreSQL and Dragonfly test databases to store data in memory
  • Added automatic unnamed volume cleanup to the down make target

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docker-compose.yml Added kdc service dependency to kadmin_api to prevent race condition on shared volume
.package/docker-compose.yml Added kdc service dependency to kadmin_api to prevent race condition on shared volume
docker-compose.test.yml Added tmpfs mounts to postgres and dragonfly services to prevent test data persistence
Makefile Added docker volume prune -f command to down target for automatic cleanup of unnamed volumes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milov-dmitriy milov-dmitriy merged commit b10d398 into dev Jan 16, 2026
12 checks passed
@milov-dmitriy milov-dmitriy deleted the optimize_docker branch January 16, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants