Skip to content

Ensure onMount triggers in iOS Safari by reordering layout structure#308

Merged
Muhammed-Rahif merged 3 commits intoalphafrom
main
Feb 23, 2025
Merged

Ensure onMount triggers in iOS Safari by reordering layout structure#308
Muhammed-Rahif merged 3 commits intoalphafrom
main

Conversation

@Muhammed-Rahif
Copy link
Owner

@Muhammed-Rahif Muhammed-Rahif commented Feb 23, 2025

No description provided.

0xSalik and others added 3 commits January 27, 2025 16:01
@0xSalik
fix: ensure onMount triggers in iOS Safari by reordering layout str…
22e1879 
…ucture

- Moved the main layout `<div>` containing `<MenuBar />` and `<EditorTabs />` outside the `isLoading` conditional block in `App.svelte`
- Prevents issues with child components' `onMount` lifecycle hooks not firing on iOS Safari
- Fixes issue #268: `onMount` not triggering for child components on iOS Safari
@Muhammed-Rahif
Merge pull request #302 from 0xSalik/main
0aa2428 
fix: resolve `onMount` lifecycle issue in iOS Safari by reordering layout structure
@Muhammed-Rahif
Merge pull request #307 from Muhammed-Rahif/alpha
92eb80d 
Alpha
@vercel
Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2025 2:06pm

@Muhammed-Rahif Muhammed-Rahif merged commit 2d5f77e into alpha Feb 23, 2025
3 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025

🙌 Woohoo, @Muhammed-Rahif! Thanks for opening a pull request to Notpad. 🛠️✨
Your efforts make this project better with every contribution.
💡 Before we merge this, don’t forget to check our CONTRIBUTING.md for a smoother process.
Together, we’re building something incredible – keep up the amazing work! 💪
(Psst... have you starred the repo yet? ⭐)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2025

🎉 Congratulations, @Muhammed-Rahif! Your pull request has been successfully merged. 🥳🎈
You’ve just made Notpad better, and we couldn’t be more thankful. 🙌
Your contribution is now part of the project, helping users and contributors around the world. 🌍
We’re excited to see what else you have in store for us – the best is yet to come! 💡
Cheers to you and the amazing world of open source! 🍻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Muhammed-Rahif @0xSalik