Add resource sharing for organization collectives #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanlasser
reviewed
Jan 6, 2026
Comment on lines
172
to
206
| ai_credit_count["monthly"] = min(amount, organization.monthly_ai_credits) | ||
| amount -= ai_credit_count["monthly"] | ||
|
|
||
| ai_credit_count["regular"] = min(amount, organization.number_ai_credits) | ||
| amount -= ai_credit_count["regular"] | ||
|
|
||
| if amount > 0: | ||
| raise InsufficientAICreditsError(amount) | ||
|
|
||
| organization.monthly_ai_credits -= ai_credit_count["monthly"] | ||
| organization.number_ai_credits -= ai_credit_count["regular"] | ||
| organization.save() | ||
|
|
||
| # Then deduct from parent resources | ||
| if parent: | ||
| parent_monthly = min(amount, parent.monthly_ai_credits) | ||
| ai_credit_count["monthly"] += parent_monthly | ||
| amount -= parent_monthly | ||
| parent.monthly_ai_credits -= parent_monthly | ||
|
|
||
| parent_regular = min(amount, parent.number_ai_credits) | ||
| ai_credit_count["regular"] += parent_regular | ||
| amount -= parent_regular | ||
| parent.number_ai_credits -= parent_regular | ||
| parent.save() | ||
|
|
||
| # Then deduct from group resources | ||
| for group in groups: | ||
| group_monthly = min(amount, group.monthly_ai_credits) | ||
| ai_credit_count["monthly"] += group_monthly | ||
| amount -= group_monthly | ||
| group.monthly_ai_credits -= group_monthly | ||
|
|
||
| group_regular = min(amount, group.number_ai_credits) | ||
| ai_credit_count["regular"] += group_regular | ||
| amount -= group_regular | ||
| group.number_ai_credits -= group_regular | ||
| group.save() |
Member
There was a problem hiding this comment.
Same comments about duplicated logic pointing to a refactoring opportunity. Seeing this logic shared between spending requests and AI credits makes that even more apparent! Doesn't need to get addressed now, but let's make sure we keep this in mind this during our payments refactor.
Contributor
|
I correctly am able to see that MuckRock and MuckRock child are on the organization plan now, so I believe the latest squarelet fixed that integration. However, MuckRock child only shows 5000 AI credits though, instead of 10,000 (5k from itself and 5k from its parent). Requests does show the correct totals - child 100 requests, parent 50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the same changes as the MuckRock repo, except for premium credits instead of requests. Also, some of the code is in the library
squarelet-authwhich DocumentCloud uses but MuckRock does not for historical reasons