Added documentation for engine modules and permissions#5264
Draft
Spoorthy1423 wants to merge 1 commit intoMovingBlocks:developfrom
Draft
Added documentation for engine modules and permissions#5264Spoorthy1423 wants to merge 1 commit intoMovingBlocks:developfrom
Spoorthy1423 wants to merge 1 commit intoMovingBlocks:developfrom
Conversation
Contributor
|
This seems incomplete and unfortunately does not make much sense. Did you try to read through and understand the codebase before writing this? Also, please try and fill-out the pull request template. It helps when trying to understand what this is at a glance. If this is not ready for review yet, you can mark it as a draft so that others will know to leave it be until you mark it as ready again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4647 Added Document on how and when to add classes/permissions/packages to engine module
-Added markdown and clearly stated requirements
Contains
Brief description of what the PR does like "Fixes #12345"
How to test
Brief description of how to test / confirm this PR before merging
Outstanding before merging
If anything. You can use neat checkboxes! Feel free to delete if not needed