Skip to content

Fix false 'not rebaseable' when GitHub API returns null#89

Merged
JBlaak merged 1 commit intomasterfrom
fix/handle-null-rebaseable
Mar 23, 2026
Merged

Fix false 'not rebaseable' when GitHub API returns null#89
JBlaak merged 1 commit intomasterfrom
fix/handle-null-rebaseable

Conversation

@JBlaak
Copy link
Member

@JBlaak JBlaak commented Mar 23, 2026

Summary

  • GitHub's API computes rebaseable asynchronously and returns null while pending
  • The existing retry logic handled mergeableState === 'unknown' but not rebaseable === null, causing eligible PRs to be incorrectly skipped with "PR #X is not rebaseable"
  • Added retry logic for null rebaseable (same pattern as mergeableState), with fallback to false after max retries

Test plan

  • Added test: retry succeeds when rebaseable transitions from null to true
  • Added test: defaults to false after max retries exhausted
  • All 35 existing tests pass

🤖 Generated with Claude Code

GitHub's API computes rebaseable asynchronously and returns null while
pending. The code already retried for unknown mergeableState but treated
null rebaseable as false, causing eligible PRs to be skipped.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@JBlaak JBlaak merged commit 3dc0cfe into master Mar 23, 2026
2 checks passed
@JBlaak JBlaak deleted the fix/handle-null-rebaseable branch March 23, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant