Open
Conversation
Heinz Wiesinger (pprkut)
requested changes
May 13, 2024
| required: false | ||
| type: string | ||
| default: 'autoload_psr-pprkut/autoload-psr@0.2.0' | ||
| php-run-extensions: |
Contributor
There was a problem hiding this comment.
Maybe we should rename the other one to phpunit-php-extensions instead? Or some such
Comment on lines
+53
to
+60
| cli-test-file: | ||
| required: false | ||
| type: string | ||
| default: 'cli.php' | ||
| cli-test-args: | ||
| required: false | ||
| type: string | ||
| default: '-vvv' |
Contributor
There was a problem hiding this comment.
I think it makes more sense to combine these two. We're just appending them later anyway
Contributor
Author
There was a problem hiding this comment.
We're using the file to indicate where the issue is with an annotation. If you have suggestions to split that later I'm fine merging them.
Contributor
There was a problem hiding this comment.
No, it's fine. I missed that, apparently. Let's leave it split then.
However, can we make the names a bit more generic? Like, php-test-file instead of cli-test-file, or exec-test-file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.