Skip to content

Fix lobby userlist and roomlist updating#36

Open
nico-abram wants to merge 4 commits into
Moutix:masterfrom
nico-abram:LobbyUpdates
Open

Fix lobby userlist and roomlist updating#36
nico-abram wants to merge 4 commits into
Moutix:masterfrom
nico-abram:LobbyUpdates

Conversation

@nico-abram
Copy link
Copy Markdown

Fix lobby room and userlist updates

@Moutix
Copy link
Copy Markdown
Owner

Moutix commented Jun 12, 2017

If I didn't send the lobby user list, it's because it's limited to 255 users do we really need to send it?

@nico-abram
Copy link
Copy Markdown
Author

I dont think sending the lobby userlist properly is a bad idea. That said i can see it not being a priority.
What i do think is a priority is the room list(without it users cant properly recognize/join rooms. Even the state is important in my opinion(a player in a hurry might be looking for a room not in a game).
And, if i remember correctly, the lobby userlist and room list are sent in the same packet(therefore not updating the userlist but updating the room list wouldnt make much difference i think)

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 84.68% when pulling 5a24975 on Nickito12:LobbyUpdates into d3353ac on ningirsu:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants