Skip to content

Fix InputStream resource leak in CritterGizmoGenerator #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanchooly merged 2 commits into from
Mar 6, 2026
+4 −5
Merged

Fix InputStream resource leak in CritterGizmoGenerator #4206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76cdf0
Initial plan
Copilot Mar 6, 2026
50f1d51
Fix resource leak: wrap InputStream in try-with-resources in CritterG…
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions core/src/main/java/dev/morphia/critter/parser/gizmo/CritterGizmoGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@ public static GizmoEntityModelGenerator generate(Class<?> type, CritterClassLoad
Generators generators, boolean runtimeMode) {
ClassNode classNode = new ClassNode();
String resourceName = "%s.class".formatted(type.getName().replace('.', '/'));
java.io.InputStream inputStream = type.getClassLoader().getResourceAsStream(resourceName);
if (inputStream == null) {
throw new IllegalArgumentException("Could not find class file for %s".formatted(type.getName()));
}
try {
try (java.io.InputStream inputStream = type.getClassLoader().getResourceAsStream(resourceName)) {
if (inputStream == null) {
throw new IllegalArgumentException("Could not find class file for %s".formatted(type.getName()));
}
new ClassReader(inputStream).accept(classNode, 0);
} catch (IOException e) {
throw new RuntimeException("Failed to read class %s".formatted(type.getName()), e);
Expand Down