feat: Logs of merging apkm files are now in FINE level#86
feat: Logs of merging apkm files are now in FINE level#86prateek-who wants to merge 4 commits intoMorpheApp:devfrom
Conversation
I've added this warning message for future use. Is this fine? Or do we create another logger class, just for this? This way we are future proof but will this be used anywhere else is the question. Either ways, let me know what you think. |
|
I think it works great how it is. Maybe we will need a |
|
We may want to wait on merging this until Manager is using patcher ARSCLib for merging, because expert mode shows the merging logs but doesn't show trace. We may need a way for Manager to change the logging of just arsclib without enabling trace (which I think is too spammy for expert mode). |
Yea, we will need to add FINER logging and move a bunch of the logs there. Right now, logging at FINE level is too noisy, everything under the sun gets printed here, it feels like. Having a FINER level would be much better. But then again, you are right on it being used for tracing generally. We need to find a middle ground
The current FINE level has way too much logs, is that intended? (I have never used any of this before so I have no clue). Maybe we could relegate some thing to FINER? |
|
Yes I think there's too much in fine and some could be finer logging. |
Logs of merging split apks are now in FINE level instead of INFO. This way we only print one line for merging apks unless specified otherwise by the user. Needs to be merged with #85