Skip to content

feat: Logs of merging apkm files are now in FINE level#86

Open
prateek-who wants to merge 4 commits intoMorpheApp:devfrom
prateek-who:better-logging-for
Open

feat: Logs of merging apkm files are now in FINE level#86
prateek-who wants to merge 4 commits intoMorpheApp:devfrom
prateek-who:better-logging-for

Conversation

@prateek-who
Copy link
Copy Markdown
Contributor

Logs of merging split apks are now in FINE level instead of INFO. This way we only print one line for merging apks unless specified otherwise by the user. Needs to be merged with #85

@prateek-who
Copy link
Copy Markdown
Contributor Author

WARNING: THIS PUTS ALL THE NORMAL MESSAGES FROM ARSCLIB INTO FINE TOO SINCE THIS IS THE ONLY PLACE THAT USES IT. IF YOU WANT TO USE THIS IN THE FUTURE, BEWARE OF USING THIS BLINDLY. 

I've added this warning message for future use. Is this fine? Or do we create another logger class, just for this? This way we are future proof but will this be used anywhere else is the question. Either ways, let me know what you think.

@LisoUseInAIKyrios
Copy link
Copy Markdown
Contributor

I think it works great how it is.

Maybe we will need a finer logging in the future, but maybe not since it's generally used for tracing.

@LisoUseInAIKyrios
Copy link
Copy Markdown
Contributor

We may want to wait on merging this until Manager is using patcher ARSCLib for merging, because expert mode shows the merging logs but doesn't show trace. We may need a way for Manager to change the logging of just arsclib without enabling trace (which I think is too spammy for expert mode).

@prateek-who
Copy link
Copy Markdown
Contributor Author

I think it works great how it is.

Maybe we will need a finer logging in the future, but maybe not since it's generally used for tracing.

Yea, we will need to add FINER logging and move a bunch of the logs there. Right now, logging at FINE level is too noisy, everything under the sun gets printed here, it feels like. Having a FINER level would be much better. But then again, you are right on it being used for tracing generally. We need to find a middle ground

I think it works great how it is.

Maybe we will need a finer logging in the future, but maybe not since it's generally used for tracing.

The current FINE level has way too much logs, is that intended? (I have never used any of this before so I have no clue). Maybe we could relegate some thing to FINER?

@LisoUseInAIKyrios
Copy link
Copy Markdown
Contributor

Yes I think there's too much in fine and some could be finer logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants