fix: recursive call for CraftServer.getGameVersion() #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It's probably no biggie, but I'm a bit worried about the variable name change. Should any plugin try to access this directly as a workaround (through reflection), it will break. |
Author
|
Oh true didn't think of that. I'll revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CraftServer.getGameVersion() recursively calls itself which results in a stack overflow. I'd like for this value to be dynamic based on the actual game version in the future but since it isn't exposed in NMS theres no trivial way to do it (and the rest of the code uses the constants) so I've just made it return the gameVersion variable for now.