[author-inherent] Move `kick_off_authorship_validation()` to `post_inherents()` by arturgontijo · Pull Request #93 · Moonsong-Labs/moonkit

arturgontijo · 2026-02-09T18:57:57Z

This PR moves the kick_off_authorship_validation() logic to the post_inherents().

It also adds integrity_test() hook with some checks.

Note: Do we need more integrity checks there? I decided to keep tests.rs simple as this new approach is.

As we see here, integrity_tests is also being tested too.

➜  moonkit git:(artur/post-inherents) cargo test -p pallet-author-inherent                                                        
warning: profile package spec `cranelift-wasm` in profile `dev` did not match any packages
    Finished `test` profile [unoptimized + debuginfo] target(s) in 1.27s
     Running unittests src/lib.rs (target/debug/deps/pallet_author_inherent-95dea1c55ff74551)

running 3 tests
test mock::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test mock::test_genesis_config_builds ... ok
test tests::test_author_is_extracted_and_stored_from_pre_runtime_digest ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

…ents()

manuelmauro · 2026-02-19T12:12:30Z

pallets/author-inherent/src/lib.rs

-		// TODO better weight. For now we just set a somewhat conservative fudge factor
-		#[pallet::call_index(0)]
-		#[pallet::weight((T::WeightInfo::kick_off_authorship_validation(), DispatchClass::Mandatory))]
-		pub fn kick_off_authorship_validation(origin: OriginFor<T>) -> DispatchResultWithPostInfo {


This function is still referenced in benchmarks pallets/author-inherent/src/benchmarks.rs and weights pallets/author-inherent/src/weights.rs.

You can run cargo build --features runtime-benchmarks to check.

manuelmauro · 2026-02-19T12:20:47Z

pallets/author-inherent/src/lib.rs

-			// https://github.com/paritytech/polkadot-sdk/issues/2841#issuecomment-1876040854
+		fn integrity_test() {
+			// Test that SlotBeacon can be called and returns a valid slot
+			let slot = T::SlotBeacon::slot();


Does this really test what is mentioned in the comment?

The idea was just to check if it can be called, as it returns u32 that is then used in the can_author() call.

manuelmauro · 2026-02-19T12:22:12Z

pallets/author-inherent/src/lib.rs

-				T::CanAuthor::can_author(&Self::get(), &new_slot),
-				"Block invalid, supplied author is not eligible."
+			// Test that CanAuthor trait can be called
+			let _ = Pallet::<T>::can_author(


Here we are discarding the result of the call without testing "// Test that CanAuthor trait can be called".

The result is false as we are not touching storage there. Not sure if we should touch it though.

manuelmauro · 2026-02-19T12:23:25Z

pallets/author-inherent/src/lib.rs

+			<Author<T>>::put(&author);
 		} else {
-			None
+			panic!("Block invalid, missing author in pre-runtime digest");


Could be useful to add a #[should_panic] test to test this branch of execution.

manuelmauro · 2026-02-19T12:25:25Z

pallets/author-inherent/Cargo.toml


 [features]
 default = [ "std" ]
 std = [


Add sp-core/std

manuelmauro · 2026-02-19T12:25:49Z

pallets/author-inherent/Cargo.toml

 sp-api = { workspace = true }
 sp-application-crypto = { workspace = true }
+sp-core = { workspace = true }
 sp-inherents = { workspace = true }


This could be removed

The GH line comment is not very clear, I mean sp-inherents = { workspace = true }

manuelmauro · 2026-02-19T12:25:59Z

pallets/author-inherent/Cargo.toml

@@ -15,6 +15,7 @@
 scale-info = { workspace = true }
 sp-api = { workspace = true }


This could be removed

Same here for sp-api = { workspace = true }

manuelmauro · 2026-02-19T12:26:35Z

pallets/author-inherent/src/lib.rs

@@ -22,13 +22,10 @@

 extern crate alloc;


Maybe this can be removed

manuelmauro · 2026-02-19T12:34:48Z

pallets/author-inherent/src/lib.rs

 // You should have received a copy of the GNU General Public License
 // along with Moonkit.  If not, see <http://www.gnu.org/licenses/>.

 //! Pallet that allows block authors to include their identity in a block via an inherent.


Outdated

//! Pallet that extracts the block author identity from the pre-runtime digest and validates //! eligibility via a `PostInherents` hook. Currently the author does not _prove_ their identity, //! just states it. So it should not be used for things like equivocation slashing that require //! authenticated authorship information.

[author-inherent] Move kick_off_authorship_validation() to post_inher…

8087446

…ents()

arturgontijo self-assigned this Feb 9, 2026

arturgontijo requested review from librelois and manuelmauro February 12, 2026 14:38

manuelmauro reviewed Feb 19, 2026

View reviewed changes

		@@ -15,6 +15,7 @@
		scale-info = { workspace = true }
		sp-api = { workspace = true }

Comments

Conversation

arturgontijo commented Feb 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants