fix(tools): auto-resolve relative paths in WriteFile #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove error for relative paths, auto-resolve to working directory - Update test to verify new behavior - Improves UX by avoiding 'Invalid path' errors on first attempt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #621
Description
Auto-resolve relative paths in WriteFile tool to improve user experience.
Problem: When LLM passes a relative path like
test.pyto WriteFile, it returns "Invalid path" error, requiring LLM to retry with absolute path. This creates unnecessary friction in the user experience.Solution: Instead of returning an error, automatically resolve relative paths to the working directory.
Changes:
src/kimi_cli/tools/file/write.py: Replace error with auto-resolutiontests/test_write_file.py: Update test to verify new behaviorChecklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.