feat(ci): add macOS code signing and notarization #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 14, 2026 15:23
stdrc
reviewed
Jan 14, 2026
| from kimi_cli.utils.pyinstaller import datas, hiddenimports | ||
|
|
||
| # Read codesign identity from environment variable (for macOS signing in CI) | ||
| codesign_identity = os.environ.get("APPLE_SIGNING_IDENTITY", None) |
Collaborator
There was a problem hiding this comment.
Suggested change
| codesign_identity = os.environ.get("APPLE_SIGNING_IDENTITY", None) | |
| codesign_identity = os.getenv("APPLE_SIGNING_IDENTITY") |
Comment on lines
+119
to
127
| # Build with signing on macOS (APPLE_SIGNING_IDENTITY is read by kimi.spec) | ||
| - name: Build standalone binary (macOS with signing) | ||
| if: runner.os == 'macOS' | ||
| run: make build-bin | ||
|
|
||
| # Build without signing on other platforms | ||
| - name: Build standalone binary | ||
| if: runner.os != 'macOS' | ||
| run: make build-bin |
Collaborator
There was a problem hiding this comment.
Seems no need to have two different step?
Collaborator
|
I'll merge this PR after we setting the secrets |
stdrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue
Description
Add macOS code signing and notarization support to the release workflow. This ensures that macOS binaries distributed via GitHub releases are properly signed and notarized, eliminating Gatekeeper warnings for users.
Changes
New GitHub Action (
.github/actions/macos-code-sign/action.yml)Updated Release Workflow (
.github/workflows/release-kimi-cli.yml)Updated PyInstaller Spec (
kimi.spec)APPLE_SIGNING_IDENTITYfrom environment variableRequired Secrets
The following secrets need to be configured in the repository:
APPLE_CERTIFICATE_P12APPLE_CERTIFICATE_PASSWORDAPPLE_NOTARIZATION_KEY_P8APPLE_NOTARIZATION_KEY_IDAPPLE_NOTARIZATION_ISSUER_IDBenefits
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.