Skip to content

add Logo invert if 85% black#172

Open
nullbyze wants to merge 3 commits into
Moonfin-Client:mainfrom
nullbyze:logo-invert
Open

add Logo invert if 85% black#172
nullbyze wants to merge 3 commits into
Moonfin-Client:mainfrom
nullbyze:logo-invert

Conversation

@nullbyze
Copy link
Copy Markdown
Contributor

Pull Request

Summary

Provide a brief description of what this PR changes and why.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • added util to detect brightness and inverted the image if mostly black

Platform

  • Tizen (Samsung)
  • webOS (LG)
  • Both / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Go to details page
  2. Look at the logo
  3. It should be white if it was black before

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2026

✅ Build Successful

All platform builds passed. You can download the test artifacts below.

Platform Status Artifact
webOS ✅ Passed Moonfin_webOS_*.ipk
Tizen Regular ✅ Passed Moonfin_Tizen_Regular_*.wgt
Tizen Oblong ✅ Passed Moonfin_Tizen_Oblong_*.wgt
Tizen Legacy ✅ Passed Moonfin_Tizen_Legacy_*.wgt
Property Value
Commit 51e4b15
Workflow run Build #70

@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

This new workflow is awesome right? it updates if you submit new commits too instead of posting new comments

@nullbyze
Copy link
Copy Markdown
Contributor Author

indeed, well done 👍

interestingly it's only wrong on github :D
@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

you just wanted to test it, didnt you

@nullbyze
Copy link
Copy Markdown
Contributor Author

ofcourse :P

@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

I think this can be achieved a different way without all the image manipulation. Why not add a drop shadow to the logo? black drop shadow on light backgrounds, white shadow on dark ones. what do you think?

image image

@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

@nullbyze
Copy link
Copy Markdown
Contributor Author

Ok seems like the simpler solution. I will try it out later

@nullbyze
Copy link
Copy Markdown
Contributor Author

nullbyze commented Apr 28, 2026

ok it's the same as i tried in the beginning. Simple, but idk that white shadow around all logos adds a blurry/muddy like look.
difference
I like the cleaner, sharper look (especially on "code of silence" whith a black and white drop shadow, looks strange), but I'm also fine with the shadow solution if you like that more.

@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

I just pushed up a commit to my branch, can you check it out please? should get rid of the blurry look.

@nullbyze
Copy link
Copy Markdown
Contributor Author

nullbyze commented May 3, 2026

thats better, but still looks a bit strange. Thats why I said with the dark detection logic you could simply invert it and we are back where we started :D
difference2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] details page title blank when no title image is present

2 participants