fix SetServerScreen layout bugs#80
Merged
Merged
Conversation
|
Can you give the user selection card the same color as the server selection card please? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request
Summary
Fixes an issue where elements on the
SetServerScreenwould not update when going to manual server entry. Also prevents a visual bug where discovered servers could appear underneath theAdd Serverscreen ifAdd Serverwas pressed beforeServerDiscoveryTaskcould finish. Additionally fixes a focus issue where both a discovered server and the Add Server button could be focused simultaneously.Related Issues
Brought up by
jdupacon the Discord server.Type of Change
Changes Made
applyManualLayout()when manual mode is set. This forces the height ofmainGroupand translation of the version to be correct.addServerButtonfrom being focused whensetDiscoveredMode()is called.updateDiscoveredLayout()is triggered during manual entry mode.errorMessagefont size and Y translation so it renders correctly insidemainGroupwhile in manual mode.Testing
Describe how this change was tested.
Checklist