Skip to content

fix SetServerScreen layout bugs#80

Merged
RadicalMuffinMan merged 8 commits into
Moonfin-Client:masterfrom
harleykradovill:master
May 12, 2026
Merged

fix SetServerScreen layout bugs#80
RadicalMuffinMan merged 8 commits into
Moonfin-Client:masterfrom
harleykradovill:master

Conversation

@harleykradovill
Copy link
Copy Markdown

@harleykradovill harleykradovill commented May 11, 2026

Pull Request

Summary

Fixes an issue where elements on the SetServerScreen would not update when going to manual server entry. Also prevents a visual bug where discovered servers could appear underneath the Add Server screen if Add Server was pressed before ServerDiscoveryTask could finish. Additionally fixes a focus issue where both a discovered server and the Add Server button could be focused simultaneously.

Related Issues

Brought up by jdupac on the Discord server.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Call applyManualLayout() when manual mode is set. This forces the height of mainGroup and translation of the version to be correct.
  • Prevent addServerButton from being focused when setDiscoveredMode() is called.
  • Hide the server picker container when updateDiscoveredLayout() is triggered during manual entry mode.
  • Adjust errorMessage font size and Y translation so it renders correctly inside mainGroup while in manual mode.

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan
Copy link
Copy Markdown

Can you give the user selection card the same color as the server selection card please?

@harleykradovill
Copy link
Copy Markdown
Author

harleykradovill commented May 12, 2026

Can you give the user selection card the same color as the server selection card please?

screenshot-2026-05-11-21 57 04 352

I also changed the style of the Sign In page

screenshot-2026-05-11-21 54 11 027

@RadicalMuffinMan RadicalMuffinMan merged commit 4a7bf14 into Moonfin-Client:master May 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants