[jagoda:fix-redirect] Clear cookie header on redirect#1
Open
iliyan wants to merge 1 commit intoMonsantoCo:masterfrom
Open
[jagoda:fix-redirect] Clear cookie header on redirect#1iliyan wants to merge 1 commit intoMonsantoCo:masterfrom
iliyan wants to merge 1 commit intoMonsantoCo:masterfrom
Conversation
In the event that a redirect invalidates the last cookie, the cookie store is cleared but the cookie header from the previous request remains. Since the request pipeline recomputes the cookie header for each request, this problem can be addressed by removing the cookie header from the request prior to redirecting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Per jagoda:fix-redirect) In the event that a redirect invalidates the last cookie, the
cookie store is cleared but the cookie header from the previous
request remains. Since the request pipeline recomputes the cookie
header for each request, this problem can be addressed by
removing the cookie header from the request prior to redirecting.