Move pre-game quip to a separate opt-in label#10481
Open
dreamscached wants to merge 2 commits intoMonika-After-Story:contentfrom
Open
Move pre-game quip to a separate opt-in label#10481dreamscached wants to merge 2 commits intoMonika-After-Story:contentfrom
dreamscached wants to merge 2 commits intoMonika-After-Story:contentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed earlier, submitting a change that moves pre-game quip into a separate label so that the game events that are not player vs Monika can choose whether to use it or not.
Unsure if it should be opt-in, though — maybe making it opt out would make more sense in terms of backwards compatibility?