Skip to content

Fix the problem that some menus do not support translation#10397

Open
Wingdinggaster656 wants to merge 5 commits intoMonika-After-Story:contentfrom
Wingdinggaster656:SubmodAndSubmods
Open

Fix the problem that some menus do not support translation#10397
Wingdinggaster656 wants to merge 5 commits intoMonika-After-Story:contentfrom
Wingdinggaster656:SubmodAndSubmods

Conversation

@Wingdinggaster656
Copy link
Copy Markdown
Contributor

While players generally don't install just one submod once they start installing them, seriously, has no one in all this time found it jarring to show Submods even when only one is installed?

I found it quite jarring anyway, so I've now made it so that it doesn't appear in plural form when there's only one submod.

Incidentally, I also:

  1. Removed some store. that were useless.
  2. Added translation support to the Submod menu. I see that _() is used every menu else, so I think that should be an oversight here.

Comment thread Monika After Story/game/screens.rpy Outdated
Comment thread Monika After Story/game/screens.rpy
Copy link
Copy Markdown
Member

@Booplicate Booplicate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a point in this. It can be more confusing to users, complicates code, possibly messes up with styles (due to different line length). Have you really seen anywhere a label change mod - mods? Should we do that for everything like:
setting - settings
hotkey - hotkeys
alert - alerts
it's weird

@Wingdinggaster656
Copy link
Copy Markdown
Contributor Author

On a second thought, I also feel as if it does seem like there's nothing wrong with keeping it as Submods all the time anymore. Yesterday for some reason the more I looked at it the more uncomfortable it became.

Let's just fix the "Submod menu not supporting translation" thing for this PR.

@dreamscached
Copy link
Copy Markdown
Contributor

While you're at it, consider doing the same to the rest of the use game_menu — they lack translation too.

@Wingdinggaster656
Copy link
Copy Markdown
Contributor Author

While you're at it, consider doing the same to the rest of the use game_menu — they lack translation too.

Good idea. Done.

@Wingdinggaster656 Wingdinggaster656 changed the title Switching between Submod and Submods correctly in the game menu Fix the problem that some menus do not support translation Apr 23, 2025
@Booplicate Booplicate added this to Bugs Sep 3, 2025
@Booplicate Booplicate moved this to Fixing in Bugs Sep 3, 2025
@Booplicate Booplicate moved this from In Progress to Code Review/Testing in Bugs Sep 3, 2025
@Booplicate Booplicate added the priority: low this isn't that important, but we see its usefulness label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low this isn't that important, but we see its usefulness

Projects

Status: Code Review/Testing

Development

Successfully merging this pull request may close these issues.

3 participants