Locale-based calendar week format#10360
Open
dreamscached wants to merge 2 commits intoMonika-After-Story:contentfrom
Open
Locale-based calendar week format#10360dreamscached wants to merge 2 commits intoMonika-After-Story:contentfrom
dreamscached wants to merge 2 commits intoMonika-After-Story:contentfrom
Conversation
dreamscached
force-pushed
the
feature/locale-based-calendar
branch
from
c1966f2 to
9d0db6d
Compare
dreamscached
force-pushed
the
feature/locale-based-calendar
branch
from
9d0db6d to
efd7dfa
Compare
Contributor
Author
|
Or, alternatively, maybe Monika could ask player about that in some random dialogue? Instead of using calendar directly. |
Booplicate
added
the
priority: low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment the calendar is hardcoded to use sunday-saturday week format, which is not used worldwide. I suggest to use
calendarmodule which in turn uses user's locale to determine first day of week.After some testing it seems that it's enough just to set
DAY_NAMESappropriately and update a constant in_setupDayButtonsfor it to seemingly work absolutely the same with the different week format.This PR only adds monday-sunday week format (e.g. used in all of the Europe, Russia, and many other countries); in case
firstweekdayreturns neither0nor6the calendar remains sunday-saturday.