Method for adding custom music#10337
Open
dreamscached wants to merge 3 commits intoMonika-After-Story:contentfrom
Open
Method for adding custom music#10337dreamscached wants to merge 3 commits intoMonika-After-Story:contentfrom
dreamscached wants to merge 3 commits intoMonika-After-Story:contentfrom
Conversation
ThePotatoGuy
requested changes
Nov 28, 2024
Booplicate
reviewed
Dec 8, 2024
Member
Booplicate
left a comment
There was a problem hiding this comment.
I kinda want to refactor the music system to allow for a more advanced player.
Furthermore I think we should be more careful with what we expose as public API, we have to live with those things basically forever, which means we can't easily change our systems.
Contributor
Author
|
If we happen to change the system, I still think we should have a way to externally add music to it; it doesn't feel right to put submod custom music to the player's music folder, instead it could be added from submod folder and played from there directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a use case for external code to add songs to the music selector menu (example how it's currently done in a hacky way)
However, it's impossible to add music to the list in a non-hacky way, as
__paginateis protected and name-mangled.This PR addresses that and adds a simple method for adding a song to the list (optionally, with setting the corresponding PM for custom music)