Implement Wine detection#10284
Open
dreamscached wants to merge 5 commits intoMonika-After-Story:contentfrom
Open
Implement Wine detection#10284dreamscached wants to merge 5 commits intoMonika-After-Story:contentfrom
dreamscached wants to merge 5 commits intoMonika-After-Story:contentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many users (especially new to Linux) mistakenly use familiar DDLC.exe file instead of DDLC.sh, which (on some distributions with preinstalled Wine) leads to unexpected behavior: missing saves, graphical artifacts etc.
This PR addresses the issue by implementing Wine detection mechanism (by checking if HKEY_LOCAL_MACHINE\Software\Wine key is present) which could possibly later integrated into splash, introduction etc.Discovered another approach. This PR now uses
wine_get_version(declaration) to check if running in Wine. More reliable than checking for Wine registry key, which can be added manually.Tested on: